Skip to content

Revert "Revert "Reload existing CA from disk on restart"" #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cooktheryan merged 1 commit into from
Dec 22, 2021
Merged

Revert "Revert "Reload existing CA from disk on restart"" #524

cooktheryan merged 1 commit into from
Dec 22, 2021

Conversation

@mangelajo
Copy link
Contributor

@mangelajo mangelajo commented Dec 22, 2021

We need this back in, it was unrelated to those failures, this is only for re-loading the microshift CA from disk to memory on
microshift service reboot, so the bootstrap for multinode would work on later patches.
Reverts #521

@cooktheryan
Copy link
Contributor

cooktheryan commented Dec 22, 2021

/test e2e-openshift-conformance-sig-node

@mangelajo
Copy link
Contributor Author

mangelajo commented Dec 22, 2021

@cooktheryan may be I misunderstood the failures?


See "systemctl status microshift.service" and "journalctl -xe" for details.
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2021-12-22T12:57:32Z"}
error: failed to execute wrapped command: exit status 1

why is that happening, is there a way to see the logs?

@mangelajo
Copy link
Contributor Author

mangelajo commented Dec 22, 2021

/test e2e-openshift-conformance-sig-node

@cooktheryan
Copy link
Contributor

cooktheryan commented Dec 22, 2021

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2021
@cooktheryan cooktheryan merged commit 6dc34b5 into main Dec 22, 2021
@cooktheryan cooktheryan deleted the revert-521-revert-499-reload-ca-on-boot branch December 22, 2021 15:35
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cooktheryan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cooktheryan cooktheryan Awaiting requested review from cooktheryan

@copejon copejon Awaiting requested review from copejon

Assignees

@cooktheryan cooktheryan

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mangelajo @cooktheryan